From 572a1dcf198295a27808f9a65f8cfc2fd0e976fe Mon Sep 17 00:00:00 2001 From: Sorrel Bri Date: Thu, 14 May 2020 21:01:04 -0700 Subject: [PATCH] patch App and ActionError components to cleanup effect --- packages/play-node-go/src/App.js | 2 ++ .../src/components/Error/ActionError/ActionError.js | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/play-node-go/src/App.js b/packages/play-node-go/src/App.js index 52ff394..e985152 100644 --- a/packages/play-node-go/src/App.js +++ b/packages/play-node-go/src/App.js @@ -36,6 +36,8 @@ function App() { dispatch({type:'SOCKET', message: 'LAUNCH', body:{nsp:'', dispatch}}); } socketConnect(); + + return () => dispatch({type: 'SOCKET', message: 'DISCONNECT', body: {}}); }, [ state.connect ]) return ( diff --git a/packages/play-node-go/src/components/Error/ActionError/ActionError.js b/packages/play-node-go/src/components/Error/ActionError/ActionError.js index 20c49e0..c9ee427 100644 --- a/packages/play-node-go/src/components/Error/ActionError/ActionError.js +++ b/packages/play-node-go/src/components/Error/ActionError/ActionError.js @@ -2,7 +2,7 @@ import React from 'react'; import './ActionError.scss'; const ActionError = (props) => { - const errorMessage = props.error; + const errorMessage = props.error || ''; return (