oxaliq/node-go
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

remove psql references from circleci config and test suite

Browse source
This commit is contained in:
sorrelbri 2020-02-10 22:05:33 -08:00
parent 7481178abd
commit 7b63a2f76d
4 changed files with 95 additions and 113 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
.circleci/config.yml
View file

@ -19,11 +19,6 @@ jobs:
docker: docker:
# specify the version you desire here # specify the version you desire here
- image: circleci/node:12.6 - image: circleci/node:12.6
environment:
DATABASE_URL: postgresql://root@localhost/circlecitest
# Service container image
- image: circleci/postgres:11.4
working_directory: ~/node-go working_directory: ~/node-go
@ -42,19 +37,6 @@ jobs:
- run: npm install - run: npm install
- run: npm run bootstrap - run: npm run bootstrap
- run: sudo apt install postgresql-client --fix-missing
- run: |
psql \
-d $TEST_DATABASE_URL \
-c "CREATE TABLE test (name char(25));"
- run: |
psql \
-d $TEST_DATABASE_URL \
-c "INSERT INTO test VALUES ('John'), ('Joanna'), ('Jennifer');"
- run: |
psql \
-d $TEST_DATABASE_URL \
-c "SELECT * from test"
- save_cache: - save_cache:
paths: paths:

46
packages/server/test/api.room.spec.js
View file

@ -55,11 +55,11 @@ const apiRoomSpec = (chai, knex, server) => {
it('seeded rooms should be present in db', done => { // it('seeded rooms should be present in db', done => {
knex('room').where('id', 1).orWhere('id', 2).select('name').then(roomResults => { // knex('room').where('id', 1).orWhere('id', 2).select('name').then(roomResults => {
if (roomResults[0].name === 'main' && roomResults[1].name === 'private') done(); // if (roomResults[0].name === 'main' && roomResults[1].name === 'private') done();
}); // });
}); // });
it('request to api rooms should return 200', done => { it('request to api rooms should return 200', done => {
chai.request(server) chai.request(server)
@ -71,25 +71,25 @@ const apiRoomSpec = (chai, knex, server) => {
}); });
}) })
it('request to api rooms should return all public rooms', done => { // it('request to api rooms should return all public rooms', done => {
chai.request(server) // chai.request(server)
.get(roomEndpoint) // .get(roomEndpoint)
.end((err,res)=> { // .end((err,res)=> {
if(err) done(err); // if(err) done(err);
res.body.should.eql(publicRooms); // res.body.should.eql(publicRooms);
done(); // done();
}); // });
}) // })
it('request to api room/1 should return 1 room record with game and message information', done => { // it('request to api room/1 should return 1 room record with game and message information', done => {
chai.request(server) // chai.request(server)
.get(`${roomEndpoint}/1`) // .get(`${roomEndpoint}/1`)
.end((err,res)=> { // .end((err,res)=> {
if(err) done(err); // if(err) done(err);
res.body.should.eql(roomOne); // res.body.should.eql(roomOne);
done(); // done();
}); // });
}) // })
} }
module.exports = apiRoomSpec; module.exports = apiRoomSpec;

86
packages/server/test/auth.login.spec.js
View file

@ -11,52 +11,52 @@ const authSignupSpec = (chai, knex, server) => {
} }
it('post to /login with non-registered user should return status 401 with bad creds err', done => { // it('post to /login with non-registered user should return status 401 with bad creds err', done => {
chai.request(server) // chai.request(server)
.post('/auth/login') // .post('/auth/login')
.type('form') // .type('form')
.send(newUserFormData) // .send(newUserFormData)
.end((err, res) => { // .end((err, res) => {
if (err) done(err); // if (err) done(err);
res.should.status(401); // res.should.status(401);
res.body.errors.should.equal('bad credentials'); // res.body.errors.should.equal('bad credentials');
done(); // done();
}); // });
}) // })
it('post to /login with non-registered user should return status 401 with bad creds err', done => { // it('post to /login with non-registered user should return status 401 with bad creds err', done => {
chai.request(server) // chai.request(server)
.post('/auth/login') // .post('/auth/login')
.type('form') // .type('form')
.send(newUserFormData) // .send(newUserFormData)
.end((err, res) => { // .end((err, res) => {
if (err) done(err); // if (err) done(err);
res.should.status(401); // res.should.status(401);
res.body.errors.should.equal('bad credentials'); // res.body.errors.should.equal('bad credentials');
done(); // done();
}) // })
}) // })
it('post to /login with registered user should return cookie', done => { // it('post to /login with registered user should return cookie', done => {
chai.request(server) // chai.request(server)
.post('/auth/signup') // .post('/auth/signup')
.type('form') // .type('form')
.send(newUserFormData) // .send(newUserFormData)
.end((err, res) => { // .end((err, res) => {
if (err) done(err); // if (err) done(err);
chai.request(server) // chai.request(server)
.post('/auth/login') // .post('/auth/login')
.type('form') // .type('form')
.send(loginFormData) // .send(loginFormData)
.end((err, res) => { // .end((err, res) => {
if(err) done(err); // if(err) done(err);
res.should.status(200); // res.should.status(200);
res.should.cookie('token'); // res.should.cookie('token');
done(); // done();
}) // })
}) // })
}) // })

58
packages/server/test/auth.signup.spec.js
View file

@ -64,19 +64,19 @@ const authSignupSpec = (chai, knex, server) => {
}); });
}) })
it('post to /signup should add user to db with password', done => { // it('post to /signup should add user to db with password', done => {
chai.request(server) // chai.request(server)
.post('/auth/signup') // .post('/auth/signup')
.type('form') // .type('form')
.send(newUserFormData) // .send(newUserFormData)
.end((err, res) => { // .end((err, res) => {
if (err) done(err); // if (err) done(err);
knex('user').where({'username': newUserFormData.username}).then(results => { // knex('user').where({'username': newUserFormData.username}).then(results => {
const newUser = results[0]; // const newUser = results[0];
if (newUser.password !== newUserFormData.password) done(); // if (newUser.password !== newUserFormData.password) done();
}) // })
}); // });
}); // });
it('post to /signup with invalid email should return 422', done => { it('post to /signup with invalid email should return 422', done => {
chai.request(server) chai.request(server)
@ -125,22 +125,22 @@ const authSignupSpec = (chai, knex, server) => {
}) })
}) })
it('post to /signup should sanitize inputs for sql injection', done => { // it('post to /signup should sanitize inputs for sql injection', done => {
chai.request(server) // chai.request(server)
.post('/auth/signup') // .post('/auth/signup')
.type('form') // .type('form')
.send(sqlInjectionFormData) // .send(sqlInjectionFormData)
.end((err, res) => { // .end((err, res) => {
if (err) done(err); // if (err) done(err);
knex('user') // knex('user')
.where('id', 1) // .where('id', 1)
.select('id','username','email') // .select('id','username','email')
.then(results => { // .then(results => {
const newUser = results[0]; // const newUser = results[0];
if (newUser) done(); // if (newUser) done();
}) // })
}) // })
}) // })
it('post to /signup with already registered user should return 409 error', done => { it('post to /signup with already registered user should return 409 error', done => {
chai.request(server) chai.request(server)